Return GrpcStreamBroadcaster instances from the streaming methods
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They just start a background task. There's no async until we're actually waiting for messages. Signed-off-by: Sahas Subramanian <[email protected]>
This makes it easier to close the streamers when they are no longer needed. Also rename the methods from `stream_*` to `*_stream`. Signed-off-by: Sahas Subramanian <[email protected]>
Now that we are exposing the `GrpcStreamBroadcaster` instances which can be closed by external parties, we need to check that existing instances are active before reusing them. Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
the
part:tests
Signed-off-by: Sahas Subramanian <[email protected]>
cwasicki
reviewed
Mar 5, 2025
| warn_on_overflow: bool = False, | ||
| ) -> Receiver[Trade]: | ||
| ) -> GrpcStreamBroadcaster[ | ||
| electricity_trading_pb2.ReceiveGridpoolTradesStreamResponse, Trade |
Collaborator
There was a problem hiding this comment.
Does this mean that downstream apps need to import these types? Is there a way around this?
Contributor
Author
There was a problem hiding this comment.
Downstream apps can say: GrpcStreamBroadcaster[Any, PublicTrade] and still be fully typed, because they only care about the output type.
But we can improve during the refactoring.
cwasicki
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to close the streamers when they are no longer
needed.
Also rename the methods from
stream_*to*_stream.